[Pidgin] #9185: /help shows /me twice on IRC

Pidgin trac at pidgin.im
Thu May 28 10:23:24 EDT 2009

#9185: /help shows /me twice on IRC
 Reporter:  chemistrydioxide        |        Owner:  rekkanoryo  
     Type:  patch                   |       Status:  new         
Milestone:  Patches Needing Review  |    Component:  unclassified
  Version:  2.5.5                   |   Resolution:              
 Keywords:  /help /me               |  

Comment(by deryni):

 From devel at c.p.i yesterday.

 (10:07:54) deryni: I'm not sure only displaying an item in the help once
 is necessarily correct, especially not if one of the duplicates is able to
 'pass' on arguments it doesn't like (commands can do that, right?).
 (11:42:52) chemistrydioxide: when i read the source i thought that
 commands were sorted by some kind of priority and that the first command
 that has a) the right name and b) makes sense in the current context will
 be used
 (11:44:30) chemistrydioxide: i don't know of any command that accepts
 arguments that one of its duplicates doesn't like
 (11:45:02) deryni: There may not be any at the moment, but if we support
 that happening then I think we need to display that there are multiples.
 But I'm not certain we do support that at the moment, I'm looking.
 (11:46:45) deryni: Ok, so we support PURPLE_CMD_RET_CONTINUE which means
 "I may or may not have done anything but keep running commands".
 (11:46:53) chemistrydioxide: libpurple(?) falls back to a duplicate of a
 command if the first one fails
 (11:47:13) deryni: That's what I was talking about. I'm open to displaying
 "help(#)" instead of "help, help" though.
 (11:48:41) chemistrydioxide: what i thought when i wrote the patch was
 that showing two /me commands to the user doesn't make sense
 (11:49:30) chemistrydioxide: i know how /me works on irc and how pidgin
 handles it on others, but the user doesn't care about this
 (11:49:45) chemistrydioxide: s/others/other protocols/
 (11:49:59) deryni: Right, for the most part this will never be an issue,
 but I don't like the idea of knowingly breaking it for the cases where it
 (11:50:46) chemistrydioxide: also right, but i wasn't aware of any other
 command duplicate
 (11:52:08) deryni: I don't know of any either.

 While I don't believe we currently have duplicate commands that fall back,
 nor do we have a way to select a given command from the set of duplicates,
 we do support this (and we support duplicate commands with different
 argument signatures). So I don't think removing the duplication entirely
 is accurate. As I said though I am open to using a count instead of direct
 duplication, and I think it would be good for /help <command> to list the
 help for all commands (or give a way to select from the set of duplicates
 like /help <command> <count> or something.

Ticket URL: <http://developer.pidgin.im/ticket/9185#comment:4>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list