[PATCH] digest-md5 SASL challenges ending with a quoted value are parsed incorrectly
evan.s at dreskin.net
Wed Jan 21 18:12:21 EST 2009
On Jan 21, 2009, at 4:05 PM, Yann Kerherve wrote:
> In the case where parse_challenge is at the last token of a
> challenge and
> this token has a quoted value, then it needs to rewind one character
> cur is positioned at the terminal NULL.
> This fixes an issue where libpurple would parse a realm value (for
> as 'myrealm"' instead of 'myrealm' resulting in chaos and failure of
> SASL negotiation.
> Attached is a patch for what I think is a copy/paste error. I've not
> seen any bug caused by that, but I guess the bug exists if a challenge
> ends with a trailing newline.
Thanks, Yann. I committed both your patches to im.pidgin.pidgin in
8b089c2f6fe2d4dd78d481892094de09dc76c1ec and have also propagated them
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 194 bytes
Desc: This is a digitally signed message part
More information about the Devel