pidgin at unreliablesource.net
Fri Jun 22 12:21:50 EDT 2007
On Fri, Jun 22, 2007 at 08:59:38AM -0700, Sean Egan wrote:
> On 6/22/07, Etan Reisner <pidgin at unreliablesource.net> wrote:
> >I still have no idea how the code in question is what makes the dialogs
> >you show in your screenshots possible.
> Etan, the issue is that there seems to be no way for a prpl to
> callback to a UI after registering, to indicate whether it succeeded
> or failed. Ideally, such a callback would be passed into the prpl
> struct's register() function, but that would force 3.0.0. I suggested
> this as one possible alternative.
> The passing of usernames and passwords was just a confusion which has
> been solved. The callback only needs to pass a PurpleAccount and a
> success boolean.
Right, and I'm trying to understand for what purpose the ui needs to know
that information. It would seem to me that neither filling in fields
correctly or automatically connecting would need that (though auto-filling
might be made easier that way).
Also, passing ui callbacks to prpl functions isn't really a good idea to
my mind, I had a long conversation with someone a number of months back
about how that makes certain kinds of things harder than they need to be
if not outright impossible (I don't remember all the details though I can
probably pull up the log if I need to).
Wouldn't it be just as effective to add a
purple_account_registered(PurpleAccount *account, gboolean success)
function to account.h and a corresponding ui_op? Which would be a minor
bump, right? Also adding a corresping account-registered signal, so that
plugins and other places can respond to it.
More information about the Devel