/pidgin/main: b822f110a36b: MXit: The maximum filesize has been ...

Jorge Villaseñor salinasv at gmail.com
Wed Jan 30 11:44:46 EST 2013


Don't you think it should be 1 * 1024 * 1024?


On Wed, Jan 30, 2013 at 2:38 AM, Andrew Victor <andrew.victor at mxit.com>wrote:

> Changeset: b822f110a36b8addf80bdd59ec2e2e82477528b8
> Author:  Andrew Victor <andrew.victor at mxit.com>
> Date:    2013-01-30 09:24 +0200
> Branch:  release-2.x.y
> URL: http://hg.pidgin.im/pidgin/main/rev/b822f110a36b
>
> Description:
>
> MXit: The maximum filesize has been increased from 150K to about 1Mb.
> If we want to support even larger file sizes, we will need to implement
> the chunked protocol extensions.
>
> diffstat:
>
>  libpurple/protocols/mxit/protocol.h |  4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diffs (14 lines):
>
> diff --git a/libpurple/protocols/mxit/protocol.h
> b/libpurple/protocols/mxit/protocol.h
> --- a/libpurple/protocols/mxit/protocol.h
> +++ b/libpurple/protocols/mxit/protocol.h
> @@ -34,8 +34,8 @@
>  #define                CP_PKT_TERM                             '\x02'
>                      /* packet terminator */
>
>
> -#define                CP_MAX_PACKET                   ( 1024 * 1024 )
>       /* maximum client protocol packet size (1 MiB) */
> -#define                CP_MAX_FILESIZE                 ( 150 * 1000 )
>      /* maximum client protocol file transfer size (150 KB) */
> +#define                CP_MAX_PACKET                   ( 1 * 1000 * 1000
> )     /* maximum client protocol packet size (1 MB) */
> +#define                CP_MAX_FILESIZE                 ( CP_MAX_PACKET -
> 1000 )        /* maximum file size (reserve some space for packet headers)
> */
>  #define                MXIT_EMOTICON_SIZE              18
>                      /* icon size for custom emoticons */
>  #define                CP_MAX_STATUS_MSG               250
>                       /* maximum status message length (in characters) */
>
>
> _______________________________________________
> Commits mailing list
> Commits at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/commits
>



-- 
Masca

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20130130/ac848dc3/attachment.html>


More information about the Devel mailing list